fix(ui): give four app-panel form controls a programmatic accessible name by xfodev · Pull Request #7594 · JSONbored/loopover

xfodev · 2026-07-20T23:32:43Z

Summary

Four form controls across the owner / playground / maintainer-settings / digest app panels had no programmatic accessible name — a sibling (non-associated) <label> or none at all — so a screen reader announced them with no name (WCAG 3.3.2 / 4.1.2). Fixed with association attributes only:

owner-panel — htmlFor="owner-repo" on the Repository label + matching id on the Input.
playground-panel — htmlFor/id pairs for the Tool select, Repo input, and Branch input.
maintainer-settings (FocusManifestEditor) — aria-label="Focus manifest editor" on the JSON textarea.
digest-panel (SubscribeForm) — aria-label="Digest notification email" on the email input.

Zero visual diff: these are association-attribute-only changes — no layout, style, text, or DOM-nesting change — so nothing rendered changes; the controls only gain a programmatic name.

Tests

Adds one regression test per file (none existed), each asserting the fixed control is reachable by its accessible name via Testing Library getByLabelText / getByRole({ name }) — a real guard against the name regressing.

UI Evidence

Playground panel (/app/playground), dark theme (loopover-ui is a dark-mode-only build — no light theme to capture). The affected Tool / Repo / Branch controls are the labeled fields in the left column. Because the change is attribute-only, before and after are pixel-identical by design — that is the point of the fix: it adds a programmatic accessible name with no visual change.

Viewport × Theme	Before	After
Desktop · Dark
Tablet · Dark
Mobile · Dark

Validation

@loopover/ui typecheck, lint (0 errors), test (163 panel tests pass incl. the 4 new a11y suites), build, and version-audit all green; rebased onto latest main

Closes #7532

…name Four controls across the owner/playground/maintainer-settings/digest panels had no programmatic label — a sibling (non-associated) <label> or none at all — so a screen reader got no accessible name (WCAG 3.3.2/4.1.2). Fixed with association attributes only, zero visual diff (no layout/style/text/nesting change), so this stays in the no-visual-change lane (JSONbored#7532): - owner-panel.tsx: `htmlFor="owner-repo"` on the Repository label + matching `id` on the Input. - playground-panel.tsx: `htmlFor`/`id` pairs for the Tool select, Repo input, and Branch input. - maintainer-settings.tsx (FocusManifestEditor): `aria-label="Focus manifest editor"` on the JSON textarea. - digest-panel.tsx (SubscribeForm): `aria-label="Digest notification email"` on the email input. Adds a regression test per file (none existed) asserting each fixed control is reachable by its accessible name via Testing Library's getByLabelText / getByRole({ name }). Closes JSONbored#7532

superagent-security · 2026-07-20T23:33:17Z

Superagent didn't find any vulnerabilities or security issues in this PR.

loopover-orb · 2026-07-20T23:37:10Z

Tip

✅ LoopOver review result - approve/merge recommended

_{Review updated: 2026-07-21 00:32:38 UTC}

8 files · 1 AI reviewer · no blockers · readiness 100/100 · CI green · clean

✅ Suggested Action - Approve/Merge

safe to merge

Review summary
This is a narrow, well-scoped accessibility fix: it adds htmlFor/id pairs or aria-label to four previously-unlabeled form controls (owner-panel Repository input, playground-panel Tool/Repo/Branch, maintainer-settings FocusManifestEditor textarea, digest-panel email input), with zero visual or behavioral change. Each fix is verified correct against the full file content — id/htmlFor pairs are unique per file and don't collide with existing ids, and each change ships a real regression test that queries by accessible name via Testing Library, which is a genuine guard against the underlying WCAG defect. The PR explicitly links issue #7532 as required.

Nits — 4 non-blocking

playground-panel.tsx and playground-panel.test.tsx are truncated in this diff view so the Tool/Repo/Branch id/htmlFor pairs and their test couldn't be independently verified beyond the visible hunk, though the visible hunk looks correct.
maintainer-settings.tsx is already ~579 lines (flagged by the size-smell scan) — not something this diff should fix, but worth a follow-up issue to split FocusManifestEditor and FieldGroup out of the file.
Consider a lightweight axe/jest-axe smoke assertion in one of the four new tests to catch future regressions of this class more broadly, though the current getByLabelText/getByRole(name) assertions are already a real guard.
If maintainer-settings.tsx keeps growing, split FocusManifestEditor into its own file per repo's apparent preference for small, focused components.

Decision drivers

✅ Code review — No blockers (1 reviewer)
✅ Gate result — Passing (No configured blocker found.)

Context & advisory signals — never blocks the verdict

Signal	Result	Evidence
Linked issue	✅ Linked	#7532
Related work	✅ No active overlap found	No same-issue or scoped active PR overlap found.
Change scope	✅ 20/20	Low review scope from cached public metadata (1 linked issue).
Validation posture	✅ 25/25	PR body includes validation/test evidence.
Contributor workload	✅ 10/10	Author activity: 70 registered-repo PR(s), 40 merged, 0 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	xfodev; Gittensor profile; 70 PR(s), 0 issue(s).
Improvement	✅ Minor	risk: clean · value: minor

Review context

Author: xfodev
Role context: outside_contributor
Public audience mode: oss maintainer
Lane context: Repository is configured for direct PR review.
Public profile languages: not available
Official Gittensor activity: 70 PR(s), 0 issue(s).
PR-specific overlap: none found.

Contributor next steps

Keep the PR focused and include validation evidence before maintainer review.

Signal definitions

Related work = same linked issue, overlapping active PRs, or title/path similarity.
Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

@loopover ask <question> answers contribution-quality Q&A with source citations and freshness.
@loopover chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

Visual preview

Route	Viewport	Before (production)	After (this PR's preview)	Diff
`/`	desktop	_{before /}	_{after /}	—
`/`	mobile	_{before / (mobile)}	_{after / (mobile)}	—

Click any thumbnail to open the full-size screenshot. Before = production · After = this PR's preview deploy.

Scroll preview

Route	Before (production)	After (this PR's preview)
`/`	_{before / (scroll)}	—

A short scroll-through clip (desktop) — click either thumbnail to open the full animation. Evidence for scroll-linked behavior a single screenshot can't show.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

Re-run LoopOver review

…as secret leaks (#7994) * fix(review): stop bare hotkey/coldkey mentions from false-positiving as secret leaks containsSecretLikeText matched the bare words "hotkey"/"coldkey" anywhere in a registry document, unlike "wallet" (already scoped to "wallet path"). A Bittensor hotkey is the standard PUBLIC miner identifier, not secret material, and appears routinely in ordinary registry content -- API paths, field names, even notes explicitly denying any such data ("No wallet/hotkey data"). Confirmed root cause of 4 mis-closed metagraphed PRs in one day (#7469, #7589, #7591, #7594). Scope hot/coldkey the same way wallet already is: require adjacency to something that actually indicates key material (a keystore path, a private-key/password/ mnemonic/seed qualifier) rather than a bare word match. Also fixes a companion bug: the privacy scrub that redacts private-rubric terms from dynamically assembled/AI-generated public text was being applied to the reviewer's own static, hardcoded secret-detection message too, rendering "...secret, wallet, PAT..." as the confusing "...secret, [context], PAT...". AdvisoryFinding gains an alreadyPublicSafe flag a producer can set when its detail/publicText has no interpolated contributor or AI content, so a fixed message an engineer already wrote and reviewed renders verbatim. Closes #7981 * fix(engine): bump loopover-engine patch version for gate-decision twin parity The #7981 fix touched src/rules/advisory.ts (formatCheckRunOutput) without a matching edit to its gate-decision twin (packages/loopover-engine/src/advisory/gate-advisory.ts), which has no such function. check-engine-parity.ts requires a version bump in that case; expected-engine.version must stay in sync with it too. * fix(scripts): resolve baseEngineVersion via git by default in engine-parity check runEngineParityChecks aliased an un-overridden baseEngineVersion straight to headEngineVersion, while its changedFiles default already resolved via a real git diff against origin/main. That asymmetry meant a genuine version bump could never be detected unless the caller passed baseEngineVersion explicitly (only runEngineParityMain did), so any branch with a single-sided gate-decision edit plus a correct version bump still failed this check. Discovered while landing the #7981 hotkey/coldkey fix, which needed exactly that bump for src/rules/advisory.ts's formatCheckRunOutput. * fix(release): sync release-please manifest with the engine version bump .release-please-manifest.json tracks packages/loopover-engine's version independently of package.json; the 3.4.0 -> 3.4.1 twin-pair parity bump needed a matching entry here too, caught by release-manifest:sync:check. --------- Co-authored-by: loopover-orb[bot] <296761690+loopover-orb[bot]@users.noreply.github.com>

xfodev requested a review from JSONbored as a code owner July 20, 2026 23:32

github-actions Bot had a problem deploying to preview/pr-7594 July 20, 2026 23:34 Failure

loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 20, 2026

loopover-orb Bot assigned xfodev Jul 20, 2026

loopover-orb Bot added the manual-review Gittensor contributor context label Jul 20, 2026

JSONbored approved these changes Jul 21, 2026

View reviewed changes

JSONbored merged commit 66e2ca0 into JSONbored:main Jul 21, 2026
9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(ui): give four app-panel form controls a programmatic accessible name#7594

fix(ui): give four app-panel form controls a programmatic accessible name#7594
JSONbored merged 1 commit into
JSONbored:mainfrom
xfodev:fix/ui-a11y-labels-7532

xfodev commented Jul 20, 2026

Uh oh!

superagent-security Bot commented Jul 20, 2026

Uh oh!

loopover-orb Bot commented Jul 20, 2026 •

edited

Loading

✅ LoopOver review result - approve/merge recommended

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

xfodev commented Jul 20, 2026

Summary

Tests

UI Evidence

Validation

Uh oh!

superagent-security Bot commented Jul 20, 2026

Uh oh!

loopover-orb Bot commented Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ LoopOver review result - approve/merge recommended

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

loopover-orb Bot commented Jul 20, 2026 •

edited

Loading